Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SNAPSHOT workflow to not have VERSION_QUALIFIER #3123

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

seanstory
Copy link
Member

part of https://github.com/elastic/search-team/issues/9111

#3119 didn't add the qualifier to the artifacts, but still did pass the qualifier to the release-manager command. This lead to errors like:

2025-01-17 12:04:45 CST | FAILURE: Build failed with an exception.
-- | --
  | 2025-01-17 12:04:45 CST |  
  | 2025-01-17 12:04:45 CST | * What went wrong:
  | 2025-01-17 12:04:45 CST | Some problems were found with the configuration of task ':checksumConnectorsSnapshotSHA512' (type 'DefaultTask').
  | 2025-01-17 12:04:45 CST | - Property '$1' specifies file '/artifacts/dra-artifacts/connectors-9.0.0-alpha1-SNAPSHOT.zip' which doesn't exist.
  | 2025-01-17 12:04:45 CST |  
  | 2025-01-17 12:04:45 CST | Reason: An input file was expected to be present but it doesn't exist.

This change should prevent release-manager from expecting an artifact for the snapshot flow that has the qualifier in its filename.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes

@seanstory seanstory requested a review from a team as a code owner January 17, 2025 18:59
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubber-stamp:

@seanstory seanstory merged commit 00d9bdc into main Jan 17, 2025
4 checks passed
@seanstory seanstory deleted the seanstory/version-qualifier-fixes branch January 17, 2025 19:20
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 3123 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants